Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove all uses of SIZEOF_VLA. #2592

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 24, 2024

This is step 1 towards removing VLAs altogether.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 24, 2024
@iphydf iphydf force-pushed the vla-size branch 3 times, most recently from 29fba89 to 933f3f7 Compare January 24, 2024 12:02
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (662c214) 73.70% compared to head (5c093c4) 73.72%.

Files Patch % Lines
toxcore/TCP_common.c 80.00% 2 Missing ⚠️
toxav/rtp.c 80.00% 1 Missing ⚠️
toxcore/friend_connection.c 75.00% 1 Missing ⚠️
toxcore/onion_client.c 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2592      +/-   ##
==========================================
+ Coverage   73.70%   73.72%   +0.02%     
==========================================
  Files         148      148              
  Lines       30339    30373      +34     
==========================================
+ Hits        22361    22394      +33     
- Misses       7978     7979       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 19 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

This is step 1 towards removing VLAs altogether.
@iphydf iphydf merged commit 5c093c4 into TokTok:master Jan 25, 2024
56 of 57 checks passed
@iphydf iphydf deleted the vla-size branch January 25, 2024 07:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants