Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix comment I broke in the events test PR. #2583

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 19, 2024

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 19, 2024
@iphydf iphydf marked this pull request as ready for review January 19, 2024 00:04
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e07248d) 71.83% compared to head (ba99d4d) 71.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2583      +/-   ##
==========================================
- Coverage   71.83%   71.76%   -0.07%     
==========================================
  Files         148      148              
  Lines       30376    30376              
==========================================
- Hits        21820    21799      -21     
- Misses       8556     8577      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf merged commit ba99d4d into TokTok:master Jan 19, 2024
54 of 56 checks passed
@iphydf iphydf deleted the no-f-response branch January 19, 2024 00:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants