Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use enum-specific pack functions for enum values. #2567

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 15, 2024

It's more obvious this way.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 15, 2024
@iphydf iphydf marked this pull request as ready for review January 15, 2024 19:43
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (afc4724) 66.98% compared to head (e2c01e4) 66.90%.

Files Patch % Lines
toxcore/tox_pack.c 45.45% 6 Missing ⚠️
toxcore/events/group_join_fail.c 0.00% 2 Missing ⚠️
toxcore/events/group_message.c 0.00% 2 Missing ⚠️
toxcore/events/group_moderation.c 0.00% 2 Missing ⚠️
toxcore/events/group_peer_exit.c 0.00% 2 Missing ⚠️
toxcore/events/group_peer_status.c 0.00% 2 Missing ⚠️
toxcore/events/group_privacy_state.c 0.00% 2 Missing ⚠️
toxcore/events/group_private_message.c 0.00% 2 Missing ⚠️
toxcore/events/group_topic_lock.c 0.00% 2 Missing ⚠️
toxcore/events/group_voice_state.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2567      +/-   ##
==========================================
- Coverage   66.98%   66.90%   -0.09%     
==========================================
  Files         146      147       +1     
  Lines       30205    30177      -28     
==========================================
- Hits        20233    20190      -43     
- Misses       9972     9987      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the enum-pack branch 2 times, most recently from 14e6df4 to 7633406 Compare January 15, 2024 20:09
@iphydf iphydf merged commit e2c01e4 into TokTok:master Jan 15, 2024
54 of 55 checks passed
@iphydf iphydf deleted the enum-pack branch January 15, 2024 22:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants