refactor: Use operator== for equality tests of Node_format.
#2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
equals
branch
2 times, most recently
from
2f31e05
to
d69bc37
Compare
It has padding bytes, so memcmp isn't necessarily safe. It is definitely unsafe for fuzzed node formats.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2545 +/- ##
==========================================
+ Coverage 69.03% 69.08% +0.04%
==========================================
Files 96 96
Lines 28029 28042 +13
==========================================
+ Hits 19350 19372 +22
+ Misses 8679 8670 -9 ☔ View full report in Codecov by Sentry. |
Green-Sky
approved these changes
Jan 11, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has padding bytes, so memcmp isn't necessarily safe. It is definitely unsafe for fuzzed node formats.
This change is