refactor: Factor out malloc+memcpy into memdup. #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
memdup
branch
2 times, most recently
from
a2341b9
to
457d69c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2538 +/- ##
==========================================
+ Coverage 68.29% 68.35% +0.06%
==========================================
Files 118 118
Lines 28162 28165 +3
==========================================
+ Hits 19232 19252 +20
+ Misses 8930 8913 -17 ☔ View full report in Codecov by Sentry. |
|
we are not using |
iphydf
force-pushed
the
memdup
branch
2 times, most recently
from
9093887
to
374b8f1
Compare
mem isn't used in NGC very much yet. This is a follow-up PR for the other malloc-call PR and shouldn't change too much at once. I think it makes sense for mem.h to have a mem_dup function in it, later. |
robinlinden
requested changes
Jan 11, 2024
iphydf
force-pushed
the
memdup
branch
2 times, most recently
from
3f3e0c3
to
25ded5d
Compare
robinlinden
approved these changes
Jan 11, 2024
iphydf
force-pushed
the
memdup
branch
3 times, most recently
from
7ea981b
to
d60caad
Compare
Only applied in one place, but perhaps later we can implement a pattern in tokstyle to find more opportunities for using memdup.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only applied in one place, but perhaps later we can implement a pattern in tokstyle to find more opportunities for using memdup.
This change is