Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Align group message sending with other send functions. #2519

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 5, 2024

None of the others use out parameters. Also no toxcore function uses out parameters for anything other than arrays and errors. This would be a first, for no good reason.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 5, 2024
@iphydf iphydf marked this pull request as ready for review January 5, 2024 14:23
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6c6c0b1) 68.92% compared to head (c9ca400) 68.99%.

Files Patch % Lines
toxcore/tox.c 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2519      +/-   ##
==========================================
+ Coverage   68.92%   68.99%   +0.06%     
==========================================
  Files          89       89              
  Lines       27781    27782       +1     
==========================================
+ Hits        19149    19167      +18     
+ Misses       8632     8615      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf
Copy link
Member Author

iphydf commented Jan 5, 2024

@JFreegman FYI this breaks the unreleased API, so toxic will need an update.

@nurupo
Copy link
Member

nurupo commented Jan 5, 2024

@iphydf the tox-bootstrapd sha256 error annotation is reported twice somehow. Maybe the lifting grep was unnecessary? Or perhaps something else is going on.

image

@iphydf
Copy link
Member Author

iphydf commented Jan 5, 2024

No, it's not unnecessary. It's just that it appears twice, and so it is grepped out twice.

@nurupo
Copy link
Member

nurupo commented Jan 5, 2024

Oh, I see. The grep is necessary. After the docker build fails, Docker quotes the command that led to the failure and its output once again, which makes the error annotation appear twice in the file we grep.

None of the others use out parameters. Also no toxcore function uses out
parameters for anything other than arrays and errors. This would be a
first, for no good reason.
@iphydf iphydf merged commit c9ca400 into TokTok:master Jan 5, 2024
51 of 53 checks passed
@iphydf iphydf deleted the return-msgid branch January 5, 2024 19:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants