Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove settings.yml in favour of hs-github-tools. #2516

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 2, 2024

Centralised settings means we can update them without having to pass all the CI checks of each repo.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 2, 2024
@iphydf iphydf marked this pull request as ready for review January 2, 2024 14:08
@iphydf iphydf requested a review from a team as a code owner January 2, 2024 14:08
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Centralised settings means we can update them without having to pass all
the CI checks of each repo.
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebafd51) 69.03% compared to head (40b5fbb) 68.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2516      +/-   ##
==========================================
- Coverage   69.03%   68.96%   -0.08%     
==========================================
  Files          89       89              
  Lines       27781    27781              
==========================================
- Hits        19180    19158      -22     
- Misses       8601     8623      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toktok-releaser toktok-releaser merged commit 40b5fbb into TokTok:master Jan 2, 2024
53 checks passed
@iphydf iphydf deleted the rm-settings-yml branch January 2, 2024 22:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants