Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use GPL license with https. #2515

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 1, 2024

This aligns with the new zig-toxcore-c repo. It is a chore, but better than changing the zig-toxcore-c license to not use https.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 1, 2024
@iphydf iphydf marked this pull request as ready for review January 1, 2024 02:07
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have diffed the license with https://www.gnu.org/licenses/gpl-3.0.txt and they exactly match.

Cirrus builds fails with:

(02:09:21) ERROR: /src/workspace/c-toxcore/BUILD.bazel:4:8: no such target '//tools:LICENSE.gpl3-https': target 'LICENSE.gpl3-https' not declared in package 'tools' defined by /src/workspace/tools/BUILD.bazel (Tip: use `query "//tools:*"` to see all the targets in that package) and referenced by '//c-toxcore:license_test'

Fix this and it should be good to go.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

This aligns with the new zig-toxcore-c repo. It is a chore, but better
than changing the zig-toxcore-c license to not use https.
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e42752) 69.01% compared to head (ebafd51) 69.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2515      +/-   ##
==========================================
+ Coverage   69.01%   69.03%   +0.02%     
==========================================
  Files          89       89              
  Lines       27781    27781              
==========================================
+ Hits        19174    19180       +6     
+ Misses       8607     8601       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf merged commit ebafd51 into TokTok:master Jan 1, 2024
52 of 53 checks passed
@iphydf iphydf deleted the gpl3-https branch January 1, 2024 12:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants