Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use pkg_search_module directly in cmake. #2502

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 26, 2023

The pkg_use_module was doing magic we used to use, but no longer need.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 26, 2023
@iphydf iphydf force-pushed the pkg-search-module branch 3 times, most recently from df58dc8 to abe47d7 Compare December 26, 2023 00:50
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00ff078) 69.03% compared to head (766e62b) 69.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
- Coverage   69.03%   69.01%   -0.03%     
==========================================
  Files          89       89              
  Lines       27770    27770              
==========================================
- Hits        19172    19165       -7     
- Misses       8598     8605       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the pkg-search-module branch 3 times, most recently from f07b499 to 47286a1 Compare December 26, 2023 01:12
The `pkg_use_module` was doing magic we used to use, but no longer need.
@iphydf iphydf marked this pull request as ready for review December 26, 2023 01:18
@toktok-releaser toktok-releaser merged commit 766e62b into TokTok:master Dec 26, 2023
52 checks passed
@iphydf iphydf deleted the pkg-search-module branch December 26, 2023 01:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants