Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplify msvc build using vcpkg. #2498

Merged
merged 1 commit into from
Jan 6, 2024
Merged

chore: Simplify msvc build using vcpkg. #2498

merged 1 commit into from
Jan 6, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 25, 2023

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 25, 2023
@iphydf iphydf force-pushed the msvc branch 18 times, most recently from f0407b6 to 39d5fb5 Compare December 26, 2023 02:49
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5cac6d7) 68.96% compared to head (b148a2a) 68.97%.

Files Patch % Lines
toxcore/LAN_discovery.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2498   +/-   ##
=======================================
  Coverage   68.96%   68.97%           
=======================================
  Files          89       89           
  Lines       27782    27787    +5     
=======================================
+ Hits        19160    19166    +6     
+ Misses       8622     8621    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the msvc branch 10 times, most recently from 74344f1 to 1ddc78b Compare December 26, 2023 11:41
@iphydf iphydf marked this pull request as ready for review December 27, 2023 04:26
@iphydf iphydf requested a review from a team as a code owner December 27, 2023 04:26
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
cmake/Dependencies.cmake Outdated Show resolved Hide resolved
@iphydf iphydf merged commit b148a2a into master Jan 6, 2024
57 checks passed
@iphydf iphydf deleted the msvc branch January 6, 2024 12:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants