fix: unpack enum function names in event impl generator #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2494 +/- ##
==========================================
+ Coverage 68.94% 68.98% +0.04%
==========================================
Files 89 89
Lines 27770 27770
==========================================
+ Hits 19145 19158 +13
+ Misses 8625 8612 -13 ☔ View full report in Codecov by Sentry. |
Green-Sky
force-pushed
the
fix_tool_in_master
branch
from
4de28d2
to
41dfb1c
Compare
iphydf
approved these changes
Dec 24, 2023
|
I wonder why automerge did not trigger. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the same changes are also in #2392 , but this makes the tool in master correct for master and helps me bring ngc_events up-to-date.
the changes where introduced in 4e603bb
This change is