chore: Fix make_single_file to support core-only. #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
make-single-file
branch
from
ccb673a
to
38389f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2484 +/- ##
==========================================
+ Coverage 69.76% 69.82% +0.05%
==========================================
Files 75 75
Lines 25999 25999
==========================================
+ Hits 18139 18153 +14
+ Misses 7860 7846 -14 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
make-single-file
branch
from
38389f1
to
101eecd
Compare
|
can we add the single files to release artifacts in the future? |
Yes, ideally we'd have some release automation but for now, it's @robinlinden and a checklist :). |
Green-Sky
approved these changes
Dec 20, 2023
iphydf
force-pushed
the
make-single-file
branch
from
101eecd
to
d3c2704
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is