Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add real timeout test #2477

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Dec 18, 2023

I am having troubles with the windows builds making mono_time a random number generator.


This change is Reviewable

@Green-Sky
Copy link
Member Author

On a different setup/repo, I am getting mostly binaries that assert like this:

MonoTimeUnixTimeIncreasesOverTime() succeeded
MonoTimeIsTimeout() succeeded
Assertion failed: !(mono_time_is_timeout(mono_time, start, 5)), file D:\a\tomato\tomato\external\toxcore\mono_time_test.cc, line 76

@Green-Sky Green-Sky added this to the v0.2.19 milestone Dec 18, 2023
@Green-Sky
Copy link
Member Author

looks like non of the cmake based compiles run the unit tests, probably because they cant fine gtest.

@Green-Sky
Copy link
Member Author

tomato-windows-msvc-x86_64(51)-good-master-debug-bad-ithink-test-only.zip
If someone could debug this debug binary, would be nice. src

@iphydf iphydf changed the title feat: add real timeout test test: add real timeout test Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (90f7496) 71.55% compared to head (0c998a7) 71.58%.
Report is 2 commits behind head on master.

Files Patch % Lines
toxcore/onion_client.c 71.66% 17 Missing ⚠️
toxcore/Messenger.c 0.00% 6 Missing ⚠️
toxcore/onion.c 83.78% 6 Missing ⚠️
toxcore/DHT.c 64.28% 5 Missing ⚠️
toxcore/logger.c 0.00% 2 Missing ⚠️
toxcore/util.c 0.00% 2 Missing ⚠️
toxav/msi.c 0.00% 1 Missing ⚠️
toxcore/network.c 66.66% 1 Missing ⚠️
toxcore/shared_key_cache.c 90.00% 1 Missing ⚠️
toxcore/tox.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2477      +/-   ##
==========================================
+ Coverage   71.55%   71.58%   +0.02%     
==========================================
  Files          75       75              
  Lines       25200    25291      +91     
==========================================
+ Hits        18033    18105      +72     
- Misses       7167     7186      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Green-Sky Green-Sky merged commit 0c998a7 into TokTok:master Dec 19, 2023
51 of 52 checks passed
@Green-Sky Green-Sky deleted the add_real_timeout_test branch December 23, 2023 19:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants