cleanup: Make group saving/loading more forgiving with data errors #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
the
cleanup
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2466 +/- ##
==========================================
- Coverage 71.60% 71.52% -0.09%
==========================================
Files 75 75
Lines 25189 25195 +6
==========================================
- Hits 18036 18020 -16
- Misses 7153 7175 +22 ☔ View full report in Codecov by Sentry. |
iphydf
approved these changes
Dec 14, 2023
JFreegman
force-pushed
the
group_save_asserts
branch
from
8817de3
to
2a6262c
Compare
Rather than aborting the process on invalid group save data we either try to continue if possible, or abort the saving/loading instead of the entire process
JFreegman
force-pushed
the
group_save_asserts
branch
from
2a6262c
to
9b3c108
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than aborting the process on invalid group save data we either try to continue if possible, or abort the saving/loading instead of the entire process. This addresses #2426
This change is