refactor: Install header for private/experimental API functions #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
packaging
JFreegman
force-pushed
the
tox_private_install
branch
2 times, most recently
from
8e5f80b
to
2fe3369
Compare
JFreegman
force-pushed
the
tox_private_install
branch
from
2fe3369
to
63fb294
Compare
iphydf
requested changes
Dec 7, 2023
JFreegman
force-pushed
the
tox_private_install
branch
3 times, most recently
from
f9cf77e
to
aea676e
Compare
iphydf
approved these changes
Dec 7, 2023
JFreegman
force-pushed
the
tox_private_install
branch
from
aea676e
to
954f23d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2453 +/- ##
==========================================
+ Coverage 74.32% 74.39% +0.06%
==========================================
Files 87 87
Lines 26264 26264
==========================================
+ Hits 19522 19538 +16
+ Misses 6742 6726 -16 ☔ View full report in Codecov by Sentry. |
This allows client developers to use the private API without needing to manually specify the header path in the source code, which may vary from system to system.
JFreegman
force-pushed
the
tox_private_install
branch
from
954f23d
to
7a6d50e
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows client developers to use the private API without needing to manually specify the header path in the source code, which may vary from system to system.
This change is