refactor: replace DEFAULT_TCP_RELAY_PORTS_COUNT with a compile-time calculation #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurupo
force-pushed
the
bootstrapd-no-insync-tcp-replay-port-count
branch
3 times, most recently
from
3312109
to
82002a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2452 +/- ##
=======================================
Coverage 74.41% 74.42%
=======================================
Files 87 87
Lines 26264 26264
=======================================
+ Hits 19545 19546 +1
+ Misses 6719 6718 -1 ☔ View full report in Codecov by Sentry. |
That way we don't have to rely on a human to remember to keep DEFAULT_TCP_RELAY_PORTS_COUNT in sync with DEFAULT_TCP_RELAY_PORTS.
nurupo
force-pushed
the
bootstrapd-no-insync-tcp-replay-port-count
branch
from
a74c324
to
26d41fc
Compare
iphydf
approved these changes
Dec 5, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we don't have to rely on a human to remember to keep
DEFAULT_TCP_RELAY_PORTS_COUNTin sync withDEFAULT_TCP_RELAY_PORTS.This change is