feat: Add groupchat API function that returns an IP address string for a peer #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
the
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2446 +/- ##
==========================================
+ Coverage 70.02% 70.09% +0.07%
==========================================
Files 75 75
Lines 25825 25890 +65
==========================================
+ Hits 18083 18147 +64
- Misses 7742 7743 +1 ☔ View full report in Codecov by Sentry. |
JFreegman
force-pushed
the
group_ip_addr
branch
23 times, most recently
from
00d5c40
to
9846f38
Compare
|
relates to #2422 |
JFreegman
force-pushed
the
group_ip_addr
branch
3 times, most recently
from
1f259de
to
7b943a2
Compare
JFreegman
force-pushed
the
group_ip_addr
branch
4 times, most recently
from
ae024f4
to
5964df6
Compare
iphydf
approved these changes
Dec 19, 2023
JFreegman
force-pushed
the
group_ip_addr
branch
2 times, most recently
from
420004e
to
a67d03f
Compare
This function will return an IP address string associated with a peer. If the peer is not accepting direct connections a placeholder value will be returned, indicating that their real IP address is unknown. We do not return TCP relay IP addresses because a TCP connection with a peer may use multiple relays simultaneously.
JFreegman
force-pushed
the
group_ip_addr
branch
from
a67d03f
to
b2315c5
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function will return an IP address string associated with a peer.
If the peer is not accepting direct connections a placeholder value
will be returned, indicating that their real IP address is unknown.
We do not return TCP relay IP addresses because a TCP connection
with a peer may use multiple relays simultaneously.
This change is