Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cancel old PR builds on docker and sonar-scan workflows. #2434

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 22, 2023

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Nov 22, 2023
@iphydf iphydf marked this pull request as ready for review November 22, 2023 21:43
@iphydf iphydf requested a review from a team as a code owner November 22, 2023 21:43
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83efb17) 74.43% compared to head (814090f) 74.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2434      +/-   ##
==========================================
+ Coverage   74.43%   74.48%   +0.05%     
==========================================
  Files          87       87              
  Lines       26255    26255              
==========================================
+ Hits        19542    19557      +15     
+ Misses       6713     6698      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also, don't error on test failures on windows (they are very flaky).
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit 814090f into TokTok:master Nov 22, 2023
53 checks passed
@iphydf iphydf deleted the freebsd-kvm branch November 22, 2023 23:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants