fix: inversed return values #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2414 +/- ##
==========================================
+ Coverage 74.43% 74.47% +0.04%
==========================================
Files 87 87
Lines 26192 26189 -3
==========================================
+ Hits 19495 19505 +10
+ Misses 6697 6684 -13
☔ View full report in Codecov by Sentry. |
robinlinden
approved these changes
Oct 27, 2023
iphydf
approved these changes
Nov 6, 2023
JFreegman
force-pushed
the
group_ping_interval
branch
2 times, most recently
from
d38cae2
to
5b72599
Compare
This was causing pings to be sent every 1-2 seconds rather than the expected interval.
JFreegman
force-pushed
the
group_ping_interval
branch
from
5b72599
to
1195271
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing pings to be sent every 1-2 seconds rather than the expected interval.
This change is