fix: Ensure we have allocators available for the error paths. #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2408 +/- ##
==========================================
- Coverage 74.54% 74.43% -0.12%
==========================================
Files 87 87
Lines 26190 26192 +2
==========================================
- Hits 19523 19495 -28
- Misses 6667 6697 +30
☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
error-paths
branch
3 times, most recently
from
964b979
to
780ff4d
Compare
iphydf
force-pushed
the
error-paths
branch
2 times, most recently
from
14d19b5
to
968da98
Compare
robinlinden
approved these changes
Sep 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can deallocate stuff.
This change is