cleanup: Remove redundant -DSODIUM_EXPORT from definitions.
#2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2407 +/- ##
==========================================
- Coverage 74.66% 74.54% -0.13%
==========================================
Files 87 87
Lines 26190 26190
==========================================
- Hits 19555 19523 -32
- Misses 6635 6667 +32 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
sodium-export
branch
from
28c4310
to
7de976b
Compare
iphydf
force-pushed
the
sodium-export
branch
2 times, most recently
from
d1786e3
to
226b379
Compare
iphydf
force-pushed
the
sodium-export
branch
from
226b379
to
bfb4e86
Compare
iphydf
force-pushed
the
sodium-export
branch
5 times, most recently
from
7ea8dca
to
9bcf018
Compare
`-DSODIUM_STATIC` implies `-DSODIUM_EXPORT`.
iphydf
force-pushed
the
sodium-export
branch
from
9bcf018
to
48dbcfe
Compare
robinlinden
approved these changes
Sep 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DSODIUM_STATICimplies-DSODIUM_EXPORT.This change is