Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make event dispatch ordered by receive time. #2392

Merged
merged 3 commits into from
Jan 15, 2024

cleanup: Remove old type-ordered event getters.

b4d8826
Select commit
Loading
Failed to load commit list.
Merged

refactor: Make event dispatch ordered by receive time. #2392

cleanup: Remove old type-ordered event getters.
b4d8826
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 15, 2024 in 1s

66.78% (-4.34%) compared to 001d00a

View this Pull Request on Codecov

66.78% (-4.34%) compared to 001d00a

Details

Codecov Report

Attention: 2078 lines in your changes are missing coverage. Please review.

Comparison is base (001d00a) 71.11% compared to head (b4d8826) 66.78%.

Files Patch % Lines
toxcore/tox_event.c 39.14% 384 Missing ⚠️
toxcore/events/group_message.c 0.00% 93 Missing ⚠️
toxcore/events/group_invite.c 0.00% 92 Missing ⚠️
toxcore/events/group_peer_exit.c 18.86% 86 Missing ⚠️
toxcore/events/group_private_message.c 0.00% 86 Missing ⚠️
toxcore/events/group_custom_packet.c 0.00% 79 Missing ⚠️
toxcore/events/group_custom_private_packet.c 0.00% 79 Missing ⚠️
toxcore/events/group_peer_name.c 0.00% 79 Missing ⚠️
toxcore/events/group_topic.c 0.00% 79 Missing ⚠️
toxcore/tox_dispatch.c 56.90% 78 Missing ⚠️
... and 33 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2392      +/-   ##
==========================================
- Coverage   71.11%   66.78%   -4.34%     
==========================================
  Files         127      146      +19     
  Lines       28517    30279    +1762     
==========================================
- Hits        20280    20221      -59     
- Misses       8237    10058    +1821

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov