fix: behaviour of group api function #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2370 +/- ##
=========================================
- Coverage 9.94% 9.93% -0.01%
=========================================
Files 141 141
Lines 32503 32503
=========================================
- Hits 3231 3229 -2
- Misses 29272 29274 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JFreegman
force-pushed
the
group_connection_status
branch
from
5014a76
to
e42b4bb
Compare
Green-Sky
reviewed
Jan 6, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 0 of 1 approvals obtained
sudden6
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
The function that tells us if we're connected to a group now behaves according to the documentation and returns true if we're attempting to connect to a group, rather than only returning true if we've connected with other peers
JFreegman
force-pushed
the
group_connection_status
branch
from
e42b4bb
to
b2ca401
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function that tells us if we're connected to a group now behaves according to the documentation and returns true if we're attempting to connect to a group, rather than only returning true if we've connected with other peers.
The original purpose of this function was to inform us if we've manually disconnected from a group. In all other instances, we are effectively "connected" in the sense that we're actively searching for the group in the DHT, if not outright connected to other peers.
This change is