fix: bug causing friend group invites to sometimes fail & improve logging #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
force-pushed
the
ngc_invite_bug_fix
branch
from
b63c9e1
to
8dc8b31
Compare
Codecov Report
@@ Coverage Diff @@
## master #2338 +/- ##
==========================================
+ Coverage 78.12% 78.15% +0.02%
==========================================
Files 140 140
Lines 31045 31053 +8
==========================================
+ Hits 24255 24268 +13
+ Misses 6790 6785 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The group privacy status was incorrectly set to private when a peer accepted a friend's group invite, which would cause handshake requests to fail in certain scenarios
JFreegman
force-pushed
the
ngc_invite_bug_fix
branch
from
8dc8b31
to
856e4fe
Compare
sudden6
approved these changes
Oct 1, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group privacy status was incorrectly set to private when a peer accepted a friend's group invite, which would cause handshake requests to fail in certain scenarios
This change is