chore: disable warning about pre C99 code #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-add-label
bot
added
the
chore
sudden6
force-pushed
the
fix/clang_overactive_warning
branch
from
8cf5d58
to
78a0a75
Compare
|
|
iphydf
approved these changes
May 24, 2022
Bumps [third_party/cmp](https://github.com/camgunz/cmp) from `4c3737d` to `e836703`. - [Release notes](https://github.com/camgunz/cmp/releases) - [Commits](camgunz/cmp@4c3737d...e836703) --- updated-dependencies: - dependency-name: third_party/cmp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
And tokstyle is better at it, covering not just direct recursion, but also (most possible instances of) recursion through function pointers.
sudden6
force-pushed
the
fix/clang_overactive_warning
branch
from
8f5923e
to
7205db7
Compare
sudden6
force-pushed
the
fix/clang_overactive_warning
branch
9 times, most recently
from
bb2caba
to
d6b6b14
Compare
This fixes an error reported by cppcheck about overflowing the callback array. The locking logic probably was broken, so I replaced it with something simpler and more robust.
sudden6
force-pushed
the
fix/clang_overactive_warning
branch
from
d6b6b14
to
4062c3a
Compare
sudden6
force-pushed
the
fix/clang_overactive_warning
branch
2 times, most recently
from
8643a55
to
62291ac
Compare
sudden6
force-pushed
the
fix/clang_overactive_warning
branch
from
62291ac
to
008d9c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
=======================================
Coverage 78.92% 78.93%
=======================================
Files 127 127
Lines 24063 24078 +15
=======================================
+ Hits 18992 19005 +13
- Misses 5071 5073 +2
Continue to review full report at Codecov.
|
JFreegman
approved these changes
May 27, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 4 of 4 files at r2, 8 of 9 files at r3, 1 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained
This was referenced Jun 4, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is