Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: make it more clear that assert and uint32_t increment both only exist if NDEBUG is not defined #2311

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

zoff99
Copy link

@zoff99 zoff99 commented Apr 26, 2022

This change is Reviewable

@auto-add-label auto-add-label bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Apr 26, 2022
@iphydf iphydf added this to the v0.2.19 milestone Apr 27, 2022
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (d0304d8) 74.47% compared to head (a1d5518) 74.46%.
Report is 2 commits behind head on master.

❗ Current head a1d5518 differs from pull request most recent head d01c116. Consider uploading reports for the commit d01c116 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
- Coverage   74.47%   74.46%   -0.02%     
==========================================
  Files          87       87              
  Lines       26189    26211      +22     
==========================================
+ Hits        19505    19517      +12     
- Misses       6684     6694      +10     
Files Coverage Δ
toxcore/DHT.c 84.62% <ø> (-0.15%) ⬇️
toxcore/events/friend_connection_status.c 82.14% <100.00%> (ø)
toxcore/events/friend_message.c 81.73% <100.00%> (ø)
toxcore/events/friend_name.c 76.84% <100.00%> (ø)
toxcore/events/friend_status.c 81.92% <100.00%> (ø)
toxcore/events/friend_status_message.c 77.08% <100.00%> (ø)
toxcore/events/friend_typing.c 81.92% <100.00%> (ø)
toxcore/network.c 86.21% <100.00%> (+0.12%) ⬆️
toxcore/bin_unpack.c 78.43% <91.66%> (+1.01%) ⬆️
toxcore/events/conference_invite.c 14.42% <0.00%> (ø)
... and 15 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit d01c116 into TokTok:master Nov 12, 2023
47 of 48 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants