-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile as C++ for windows builds. #227
Conversation
Reviewed 2 of 2 files at r1. toxcore/network.c, line 173 at r1 (raw file):
The fourth argument of toxcore/network.c, line 199 at r1 (raw file):
The fourth argument of Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. toxcore/network.c, line 173 at r1 (raw file):
|
a4bb15a
to
b0f7480
Compare
Compiling as C++ changes nothing semantically, but ensures that we don't break C++ compatibility while also retaining C compatibility. C++ compatibility is useful for tooling and additional diagnostics and analyses.
Reviewed 7 of 12 files at r2. toxcore/network.c, line 173 at r1 (raw file):
|
Review status: 9 of 14 files reviewed at latest revision, 2 unresolved discussions. toxcore/network.c, line 173 at r1 (raw file):
|
Review status: 9 of 14 files reviewed at latest revision, 2 unresolved discussions. toxcore/network.c, line 173 at r1 (raw file):
|
Review status: 9 of 14 files reviewed at latest revision, 2 unresolved discussions. toxcore/network.c, line 173 at r1 (raw file):
|
Review status: 9 of 14 files reviewed at latest revision, 2 unresolved discussions. toxcore/network.c, line 173 at r1 (raw file):
|
toxcore/network.c, line 173 at r1 (raw file):
|
Reviewed 5 of 12 files at r2. Comments from Reviewable |
Nice branch name btw, totally Windows :P |
Compiling as C++ changes nothing semantically, but ensures that we don't
break C++ compatibility while also retaining C compatibility.
C++ compatibility is useful for tooling and additional diagnostics and
analyses.
This change is