Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some internal "group chat" thing to "conference". #218

Merged
merged 1 commit into from
Oct 30, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions toxav/toxav_old.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ int toxav_add_av_groupchat(struct Tox *tox, void (*audio_callback)(void *, int,
uint8_t, unsigned int, void *), void *userdata)
{
Messenger *m = (Messenger *)tox;
return add_av_groupchat(m->log, (Group_Chats *)m->group_chat_object,
return add_av_groupchat(m->log, (Group_Chats *)m->conferences_object,
(void (*)(Messenger *, int, int, const int16_t *, unsigned int, uint8_t, unsigned int, void *))audio_callback,
userdata);
}
Expand All @@ -60,9 +60,9 @@ int toxav_join_av_groupchat(struct Tox *tox, int32_t friendnumber, const uint8_t
void *userdata)
{
Messenger *m = (Messenger *)tox;
return join_av_groupchat(m->log, (Group_Chats *)m->group_chat_object, friendnumber, data, length, (void (*)(Messenger *,
int, int,
const int16_t *, unsigned int, uint8_t, unsigned int, void *))audio_callback, userdata);
return join_av_groupchat(m->log, (Group_Chats *)m->conferences_object, friendnumber, data, length,
(void (*)(Messenger *, int, int, const int16_t *, unsigned int, uint8_t, unsigned int, void *))audio_callback,
userdata);
}

/* Send audio to the group chat.
Expand All @@ -82,5 +82,5 @@ int toxav_group_send_audio(struct Tox *tox, int groupnumber, const int16_t *pcm,
unsigned int sample_rate)
{
Messenger *m = (Messenger *)tox;
return group_send_audio((Group_Chats *)m->group_chat_object, groupnumber, pcm, samples, channels, sample_rate);
return group_send_audio((Group_Chats *)m->conferences_object, groupnumber, pcm, samples, channels, sample_rate);
}
21 changes: 11 additions & 10 deletions toxcore/Messenger.c
Original file line number Diff line number Diff line change
Expand Up @@ -979,27 +979,28 @@ static int write_cryptpacket_id(const Messenger *m, int32_t friendnumber, uint8_
m->friendlist[friendnumber].friendcon_id), packet, length + 1, congestion_control) != -1;
}

/**********GROUP CHATS************/
/**********CONFERENCES************/


/* Set the callback for group invites.
/* Set the callback for conference invites.
*
* Function(Messenger *m, uint32_t friendnumber, uint8_t *data, uint16_t length, void *userdata)
*/
void m_callback_group_invite(Messenger *m, void (*function)(Messenger *m, uint32_t, const uint8_t *, uint16_t, void *))
void m_callback_conference_invite(Messenger *m, void (*function)(Messenger *m, uint32_t, const uint8_t *, uint16_t,
void *))
{
m->group_invite = function;
m->conference_invite = function;
}


/* Send a group invite packet.
/* Send a conference invite packet.
*
* return 1 on success
* return 0 on failure
*/
int send_group_invite_packet(const Messenger *m, int32_t friendnumber, const uint8_t *data, uint16_t length)
int send_conference_invite_packet(const Messenger *m, int32_t friendnumber, const uint8_t *data, uint16_t length)
{
return write_cryptpacket_id(m, friendnumber, PACKET_ID_INVITE_GROUPCHAT, data, length, 0);
return write_cryptpacket_id(m, friendnumber, PACKET_ID_INVITE_CONFERENCE, data, length, 0);
}

/****************FILE SENDING*****************/
Expand Down Expand Up @@ -2175,13 +2176,13 @@ static int handle_packet(void *object, int i, const uint8_t *temp, uint16_t len,
break;
}

case PACKET_ID_INVITE_GROUPCHAT: {
case PACKET_ID_INVITE_CONFERENCE: {
if (data_length == 0) {
break;
}

if (m->group_invite) {
(*m->group_invite)(m, i, data, data_length, userdata);
if (m->conference_invite) {
(*m->conference_invite)(m, i, data, data_length, userdata);
}

break;
Expand Down
23 changes: 12 additions & 11 deletions toxcore/Messenger.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ enum {
#define PACKET_ID_FILE_SENDREQUEST 80
#define PACKET_ID_FILE_CONTROL 81
#define PACKET_ID_FILE_DATA 82
#define PACKET_ID_INVITE_GROUPCHAT 96
#define PACKET_ID_INVITE_CONFERENCE 96
#define PACKET_ID_ONLINE_PACKET 97
#define PACKET_ID_DIRECT_GROUPCHAT 98
#define PACKET_ID_MESSAGE_GROUPCHAT 99
#define PACKET_ID_LOSSY_GROUPCHAT 199
#define PACKET_ID_DIRECT_CONFERENCE 98
#define PACKET_ID_MESSAGE_CONFERENCE 99
#define PACKET_ID_LOSSY_CONFERENCE 199

/* All packets starting with a byte in this range can be used for anything. */
#define PACKET_ID_LOSSLESS_RANGE_START 160
Expand Down Expand Up @@ -248,8 +248,8 @@ struct Messenger {
void (*friend_connectionstatuschange_internal)(struct Messenger *m, uint32_t, uint8_t, void *);
void *friend_connectionstatuschange_internal_userdata;

void *group_chat_object; /* Set by new_groupchats()*/
void (*group_invite)(struct Messenger *m, uint32_t, const uint8_t *, uint16_t, void *);
void *conferences_object; /* Set by new_groupchats()*/
void (*conference_invite)(struct Messenger *m, uint32_t, const uint8_t *, uint16_t, void *);

void (*file_sendrequest)(struct Messenger *m, uint32_t, uint32_t, uint32_t, uint64_t, const uint8_t *, size_t,
void *);
Expand Down Expand Up @@ -531,20 +531,21 @@ void m_callback_connectionstatus_internal_av(Messenger *m, void (*function)(Mess
*/
void m_callback_core_connection(Messenger *m, void (*function)(Messenger *m, unsigned int, void *));

/**********GROUP CHATS************/
/**********CONFERENCES************/

/* Set the callback for group invites.
/* Set the callback for conference invites.
*
* Function(Messenger *m, uint32_t friendnumber, uint8_t *data, uint16_t length, void *userdata)
*/
void m_callback_group_invite(Messenger *m, void (*function)(Messenger *m, uint32_t, const uint8_t *, uint16_t, void *));
void m_callback_conference_invite(Messenger *m, void (*function)(Messenger *m, uint32_t, const uint8_t *, uint16_t,
void *));

/* Send a group invite packet.
/* Send a conference invite packet.
*
* return 1 on success
* return 0 on failure
*/
int send_group_invite_packet(const Messenger *m, int32_t friendnumber, const uint8_t *data, uint16_t length);
int send_conference_invite_packet(const Messenger *m, int32_t friendnumber, const uint8_t *data, uint16_t length);

/****************FILE SENDING*****************/

Expand Down
40 changes: 20 additions & 20 deletions toxcore/group.c
Original file line number Diff line number Diff line change
Expand Up @@ -1024,7 +1024,7 @@ int invite_friend(Group_Chats *g_c, int32_t friendnumber, int groupnumber)
memcpy(invite + 1, &groupchat_num, sizeof(groupchat_num));
memcpy(invite + 1 + sizeof(groupchat_num), g->identifier, GROUP_IDENTIFIER_LENGTH);

if (send_group_invite_packet(g_c->m, friendnumber, invite, sizeof(invite))) {
if (send_conference_invite_packet(g_c->m, friendnumber, invite, sizeof(invite))) {
return 0;
}

Expand Down Expand Up @@ -1084,7 +1084,7 @@ int join_groupchat(Group_Chats *g_c, int32_t friendnumber, uint8_t expected_type
memcpy(response + 1, &group_num, sizeof(uint16_t));
memcpy(response + 1 + sizeof(uint16_t), data, sizeof(uint16_t) + GROUP_IDENTIFIER_LENGTH);

if (send_group_invite_packet(g_c->m, friendnumber, response, sizeof(response))) {
if (send_conference_invite_packet(g_c->m, friendnumber, response, sizeof(response))) {
uint16_t other_groupnum;
memcpy(&other_groupnum, data, sizeof(other_groupnum));
other_groupnum = ntohs(other_groupnum);
Expand Down Expand Up @@ -1377,7 +1377,7 @@ int group_title_get(const Group_Chats *g_c, int groupnumber, uint8_t *title)
static void handle_friend_invite_packet(Messenger *m, uint32_t friendnumber, const uint8_t *data, uint16_t length,
void *userdata)
{
Group_Chats *g_c = (Group_Chats *)m->group_chat_object;
Group_Chats *g_c = (Group_Chats *)m->conferences_object;

if (length <= 1) {
return;
Expand Down Expand Up @@ -1583,7 +1583,7 @@ static unsigned int send_peer_kill(Group_Chats *g_c, int friendcon_id, uint16_t
{
uint8_t packet[1];
packet[0] = PEER_KILL_ID;
return send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_GROUPCHAT, group_num, packet, sizeof(packet));
return send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_CONFERENCE, group_num, packet, sizeof(packet));
}


Expand All @@ -1594,7 +1594,7 @@ static unsigned int send_peer_query(Group_Chats *g_c, int friendcon_id, uint16_t
{
uint8_t packet[1];
packet[0] = PEER_QUERY_ID;
return send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_GROUPCHAT, group_num, packet, sizeof(packet));
return send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_CONFERENCE, group_num, packet, sizeof(packet));
}

/* return number of peers sent on success.
Expand All @@ -1617,7 +1617,7 @@ static unsigned int send_peers(Group_Chats *g_c, int groupnumber, int friendcon_

for (i = 0; i < g->numpeers; ++i) {
if ((p - packet) + sizeof(uint16_t) + crypto_box_PUBLICKEYBYTES * 2 + 1 + g->group[i].nick_len > sizeof(packet)) {
if (send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_GROUPCHAT, group_num, packet, (p - packet))) {
if (send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_CONFERENCE, group_num, packet, (p - packet))) {
sent = i;
} else {
return sent;
Expand All @@ -1640,7 +1640,7 @@ static unsigned int send_peers(Group_Chats *g_c, int groupnumber, int friendcon_
}

if (sent != i) {
if (send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_GROUPCHAT, group_num, packet, (p - packet))) {
if (send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_CONFERENCE, group_num, packet, (p - packet))) {
sent = i;
}
}
Expand All @@ -1649,7 +1649,7 @@ static unsigned int send_peers(Group_Chats *g_c, int groupnumber, int friendcon_
uint8_t Packet[1 + g->title_len];
Packet[0] = PEER_TITLE_ID;
memcpy(Packet + 1, g->title, g->title_len);
send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_GROUPCHAT, group_num, Packet, sizeof(Packet));
send_packet_group_peer(g_c->fr_c, friendcon_id, PACKET_ID_DIRECT_CONFERENCE, group_num, Packet, sizeof(Packet));
}

return sent;
Expand Down Expand Up @@ -1778,7 +1778,7 @@ static unsigned int send_message_all_close(const Group_Chats *g_c, int groupnumb
continue;
}

if (send_packet_group_peer(g_c->fr_c, g->close[i].number, PACKET_ID_MESSAGE_GROUPCHAT, g->close[i].group_number, data,
if (send_packet_group_peer(g_c->fr_c, g->close[i].number, PACKET_ID_MESSAGE_CONFERENCE, g->close[i].group_number, data,
length)) {
++sent;
}
Expand Down Expand Up @@ -1818,7 +1818,7 @@ static unsigned int send_lossy_all_close(const Group_Chats *g_c, int groupnumber
continue;
}

if (send_lossy_group_peer(g_c->fr_c, g->close[i].number, PACKET_ID_LOSSY_GROUPCHAT, g->close[i].group_number, data,
if (send_lossy_group_peer(g_c->fr_c, g->close[i].number, PACKET_ID_LOSSY_CONFERENCE, g->close[i].group_number, data,
length)) {
++sent;
}
Expand All @@ -1843,7 +1843,7 @@ static unsigned int send_lossy_all_close(const Group_Chats *g_c, int groupnumber
}
}

if (send_lossy_group_peer(g_c->fr_c, g->close[to_send].number, PACKET_ID_LOSSY_GROUPCHAT,
if (send_lossy_group_peer(g_c->fr_c, g->close[to_send].number, PACKET_ID_LOSSY_CONFERENCE,
g->close[to_send].group_number, data, length)) {
++sent;
}
Expand All @@ -1867,7 +1867,7 @@ static unsigned int send_lossy_all_close(const Group_Chats *g_c, int groupnumber
return sent;
}

if (send_lossy_group_peer(g_c->fr_c, g->close[to_send_other].number, PACKET_ID_LOSSY_GROUPCHAT,
if (send_lossy_group_peer(g_c->fr_c, g->close[to_send_other].number, PACKET_ID_LOSSY_CONFERENCE,
g->close[to_send_other].group_number, data, length)) {
++sent;
}
Expand Down Expand Up @@ -2136,7 +2136,7 @@ static int handle_packet(void *object, int friendcon_id, const uint8_t *data, ui
return handle_packet_online(g_c, friendcon_id, data + 1, length - 1);
}

if (data[0] != PACKET_ID_DIRECT_GROUPCHAT && data[0] != PACKET_ID_MESSAGE_GROUPCHAT) {
if (data[0] != PACKET_ID_DIRECT_CONFERENCE && data[0] != PACKET_ID_MESSAGE_CONFERENCE) {
return -1;
}

Expand All @@ -2156,12 +2156,12 @@ static int handle_packet(void *object, int friendcon_id, const uint8_t *data, ui
}

switch (data[0]) {
case PACKET_ID_DIRECT_GROUPCHAT: {
case PACKET_ID_DIRECT_CONFERENCE: {
handle_direct_packet(g_c, groupnumber, data + 1 + sizeof(uint16_t), length - (1 + sizeof(uint16_t)), index, userdata);
break;
}

case PACKET_ID_MESSAGE_GROUPCHAT: {
case PACKET_ID_MESSAGE_CONFERENCE: {
handle_message_packet_group(g_c, groupnumber, data + 1 + sizeof(uint16_t), length - (1 + sizeof(uint16_t)), index,
userdata);
break;
Expand Down Expand Up @@ -2244,7 +2244,7 @@ static int handle_lossy(void *object, int friendcon_id, const uint8_t *data, uin
return -1;
}

if (data[0] != PACKET_ID_LOSSY_GROUPCHAT) {
if (data[0] != PACKET_ID_LOSSY_CONFERENCE) {
return -1;
}

Expand Down Expand Up @@ -2452,8 +2452,8 @@ Group_Chats *new_groupchats(Messenger *m)

temp->m = m;
temp->fr_c = m->fr_c;
m->group_chat_object = temp;
m_callback_group_invite(m, &handle_friend_invite_packet);
m->conferences_object = temp;
m_callback_conference_invite(m, &handle_friend_invite_packet);

return temp;
}
Expand Down Expand Up @@ -2489,8 +2489,8 @@ void kill_groupchats(Group_Chats *g_c)
del_groupchat(g_c, i);
}

m_callback_group_invite(g_c->m, NULL);
g_c->m->group_chat_object = 0;
m_callback_conference_invite(g_c->m, NULL);
g_c->m->conferences_object = NULL;
free(g_c);
}

Expand Down
Loading