Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable toxcore logging when building on Travis. #2

Merged
merged 1 commit into from
Jul 7, 2016
Merged

Enable toxcore logging when building on Travis. #2

merged 1 commit into from
Jul 7, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jul 7, 2016 •
edited
Loading

The logging code is rarely tested by users, so we use Travis to exercise it.

This change is Reviewable

@iphydf
Enable toxcore logging when building on Travis.
7dab040 
The logging code is rarely tested by users, so we use Travis to exercise it.
@coveralls
Copy link

coveralls commented Jul 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 70.441% when pulling 7dab040 on iphydf:enable-logging into 83f5258 on TokTok:master.

@nurupo
Copy link
Member

nurupo commented Jul 7, 2016

:lgtm:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf merged commit 7dab040 into TokTok:master Jul 7, 2016
@iphydf iphydf deleted the enable-logging branch July 8, 2016 11:51
iphydf referenced this pull request in iphydf/c-toxcore Sep 6, 2016
@JFreegman
Fix two minor bugs
1275667 
Fix #1: No longer allow clients to create multiple instances with the same chat_id
Fix #2: Properly timeout group join attempts even when not connected to the DHT
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
@pranomostro pranomostro mentioned this pull request Feb 16, 2017
Closed
@tox-user tox-user mentioned this pull request Jan 29, 2018
Closed
@VVD VVD mentioned this pull request Jul 15, 2018
Closed
@jackzhp jackzhp mentioned this pull request Aug 11, 2018
Closed
restyled-io bot pushed a commit that referenced this pull request Dec 19, 2021
@JFreegman
Use compound literals instead of memset
b39b3aa 
Attempt #2
restyled-io bot pushed a commit that referenced this pull request Dec 21, 2021
@JFreegman
Use compound literals instead of memset
d811d0e 
Attempt #2
goldroom referenced this pull request in goldroom/c-toxcore Jun 28, 2023
@goldroom
Added debugging code to log behavior, fixed bug in . Currently decryp…
f02b8a5 
…tion #2 fails on the handshake packet from INITIATOR to RESPONDER. Adapted encryption/decryption functions, but not fixed yet.
@emdee-is emdee-is mentioned this pull request Dec 13, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nurupo nurupo

Labels
None yet
Projects
None yet
Milestone
v0.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@iphydf @coveralls @nurupo