Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme, moved the roadmap to a higher position #196

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

GrayHatter
Copy link

No description provided.

- [X] Make toxcore stateless
- [ ] Messenger
- [ ] Improve group chat implementation
- [ ] Improve A/V implementation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come Improving A/V is a Messenger thing, while Make ToxAV stateless is a toxcore thing?

Also, it's not clear at all what this Messenger thing is to someone who's not familiar with toxcore already.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the former (in my head) is changing the public API, giving more control to the clients. Whereas making it stateless allows us to remove the thread_mutexes from a deeper level.

Inprovments to ToxAV could be solely in ToxAV (which sits on top of messenger), making it stateless requires you to know about ToxAV and Toxcore.

I don't know how to make Messenger more clear, I'm open to suggestions.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you could simply not "expose" it in README.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'exposing' this information is better than the alternatives. WONTFIX

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except that you're not exposing something that is "information", but useless spam. For it to not be spam, you would need to provide a handy explanation what the whole Messenger thing is. Only then it would be an information.

I think 'exposing' this information is better than the alternatives. (…)

Generally exposing info is nice, but README.md doesn't seem to be the place that would benefit from exposing info about toxcore internals there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree

@@ -58,4 +61,3 @@ However, Tox does use [TCP relays](/docs/TCP_Network.txt) as a fallback if it en
### Connecting & Communicating
Every peer is represented as a [byte string](https://en.wikipedia.org/wiki/String_(computer_science)) (the public key [Tox ID] of the peer). By using torrent-style DHT, peers can find the IP of other peers by using their Tox ID. Once the IP is obtained, peers can initiate a [secure](/docs/updates/Crypto.md) connection with each other. Once the connection is made, peers can exchange messages, send files, start video chats, etc. using encrypted communications.


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more line could be removed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like a single blank line in *.md files

@@ -45,6 +34,20 @@ to developers/contributors.
- [X] Implement Crypto
- [X] Create Messenger

## Q&A:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could add a statement about security vs privacy vs anonymity, because tox provides the first two by default but anonymity requires extra effort. This issue comes up pretty frequently (ie. can my friend see my IP address?).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudden6 I agree with the idea of it being needed. But I don't think it belongs in the main readme. IMO, the whole documentation can/should be rewritten and reorganized. But that's out of the scope of this pull.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would fit very good into a FAQ section, because it's some common misconception about Tox, but I agree, it doesn't have to be in this PR.

@GrayHatter
Copy link
Author

@iphydf no blocking reviews, :shipit:

@iphydf iphydf merged commit 405dd9b into TokTok:master Oct 24, 2016

### No, really, what's Tox?

It's a VERY secure Instant Messenger that supports Text, Audio/Video calls, group chats, audio group chats, and file transfers. There's dozens, but our advantage is we put security first, from day 1. We didn't decide to add it in after.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There _is_ dozens?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your right, but that already existed, this didn't add it...

Copy link
Member

@nurupo nurupo Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did it exist? I don't see

There's dozens, but our advantage is we put security first, from day 1. We didn't decide to add it in after.

existing before this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you have added that sentance in this PR.

@iphydf iphydf modified the milestone: v0.0.3 Nov 5, 2016
@GrayHatter GrayHatter deleted the readme branch November 19, 2016 07:18
@GrayHatter GrayHatter restored the readme branch November 19, 2016 07:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants