Add option to set test timeout #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurupo
force-pushed
the
add-cmake-check-timeout
branch
from
6f36a79
to
b8b9789
Compare
Some tests take 20 or more minutes to run before they timeout, this allows to limit their runtime if needed.
|
Would it make sense to also use this on Travis? Perhaps you can set it to 5 minutes. This is per-test, right? None of our tests currently run in more than 300 seconds, and if #173 and its follow-up PR (removing tests from each file to have separate files for each test) it merged, that time will be further reduced. |
|
It is per test, e.g. |
iphydf
approved these changes
Oct 5, 2016
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests take 20 or more minutes to run before they timeout, this allows
to limit their runtime if needed.