Import the hstox SUT interface from hstox. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
hstox
branch
5 times, most recently
from
ff0409e
to
e11ad06
Compare
GrayHatter
approved these changes
Oct 1, 2016
| git clone --recursive --depth=1 https://github.com/TokTok/hstox ../hstox | ||
| # Fetch hstox and msgpack-c. | ||
| git clone --recursive --depth=1 https://github.com/TokTok/hs-toxcore ../hs-toxcore | ||
| git clone --depth=1 https://github.com/msgpack/msgpack-c testing/hstox/msgpack-c |
There was a problem hiding this comment.
The hstox build is the shortest of the 5, with 2 minutes 38 seconds on the latest build, vs. 4-5 minutes for the others. It wouldn't help and just add complexity at this point. Perhaps if hstox becomes very large and compiling it takes significant time (right now it's about 10 seconds), we can add caching.
Oh, and msgpack-c is not built. It's compiled directly as part of building the SUT. Installing it and caching its install would take more time than just compiling the 5 extra C files every time.
iphydf
force-pushed
the
hstox
branch
2 times, most recently
from
6dce4ae
to
0fd4a72
Compare
We'll maintain it in the c-toxcore repo, where it belongs.
|
FYI, I restarted a build job with a segfault in toxav. None of this code changes toxav so I'm happy to file it under fluke, that said. It's a strange fluke to see. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll maintain it in the c-toxcore repo, where it belongs.