Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant callback objects. #174

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Remove redundant callback objects. #174

merged 1 commit into from
Sep 27, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 27, 2016

These three objects and their callback IDs are always the same.

@iphydf
Remove redundant callback objects.
95b8365 
These three objects and their callback IDs are always the same.
JFreegman
JFreegman approved these changes Sep 27, 2016
View reviewed changes
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this redundancy was on purpose. I wonder why.

@iphydf iphydf merged commit 95b8365 into TokTok:master Sep 27, 2016
@iphydf iphydf deleted the remove-redundant-objects branch September 27, 2016 15:41
@iphydf iphydf modified the milestone: v0.0.1 Nov 5, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFreegman JFreegman JFreegman approved these changes

Assignees

@JFreegman JFreegman

Labels
None yet
Projects
None yet
Milestone
v0.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@iphydf @JFreegman