Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version-sync script. #166

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Add version-sync script. #166

merged 1 commit into from
Sep 28, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 23, 2016

This will update tox.in.h only. Currently, you will still need to
manually update tox.h. An upcoming PR (#154) will update tox.h as
part of the build.

@nurupo
Copy link
Member

nurupo commented Sep 24, 2016

Doesn't changing the versions directly in the source files break the promise of out-of-tree building not to litter the source tree? e.g. if you build tox like mkdir build && cd build && cmake .. you don't expect it to go and modify the source files.

@iphydf
Copy link
Member Author

iphydf commented Sep 24, 2016

This script won't change any source files unless you change the CMakeLists.txt file, in which case you break the promise yourself. This script just makes sure that if you change one place, the other places are also changed.

@nurupo
Copy link
Member

nurupo commented Sep 25, 2016

I see, the source files would already have the versions set to the same values as in CMakeLists.txt file when someone git clones / gets a tarball, so changing them again to the same values would be a no-op. Actually, looking at the shell script, it won't even modify the original the file if versions didn't change.

Copy link

@GrayHatter GrayHatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need a Pull to test formatting, you can ignore this

@GrayHatter GrayHatter assigned cleverca22 and unassigned cleverca22 Sep 26, 2016
@iphydf iphydf changed the title Add version-sync script to update all places with versions. Add version-sync script. Sep 26, 2016
@iphydf iphydf force-pushed the version-sync branch 2 times, most recently from 41af4c3 to 5f56be7 Compare September 26, 2016 10:04
@nurupo
Copy link
Member

nurupo commented Sep 27, 2016

No patch commits :\

Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@GrayHatter
Copy link

@iphydf :shipit:

This will update tox.in.h only. Currently, you will still need to
manually update tox.h. An upcoming PR (TokTok#154) will update tox.h as
part of the build.
@iphydf iphydf merged commit 36f40f1 into TokTok:master Sep 28, 2016
@iphydf iphydf deleted the version-sync branch October 18, 2016 11:13
@iphydf iphydf modified the milestone: v0.0.1 Nov 5, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants