-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that all TODOs have an owner. #133
Conversation
ea0595f
to
3ce83f4
Compare
eaebca9
to
7aa7ae0
Compare
Reviewed 26 of 26 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Reviewed 19 of 19 files at r3. Comments from Reviewable |
50052db
to
b225cb8
Compare
Reviewed 6 of 16 files at r4. toxcore/Messenger.c, line 2442 at r4 (raw file):
this should either be removed, or assigned to @mannol The argument for removing: toxav doesn't need additional or less time, even if we do need to reduce this number for toxav (unlikely IMO) then it should be renamed to messenger min and we should ignore it when toxav is active. finally; this should be dropped completely. Messenger isn't smarter than crypto_run_interval. and if it is, we should fix that, no this. Comments from Reviewable |
Reviewed 10 of 16 files at r4. Comments from Reviewable |
c8863f3
to
f762ad7
Compare
Review status: 31 of 32 files reviewed at latest revision, 1 unresolved discussion. toxcore/Messenger.c, line 2442 at r4 (raw file):
|
In the future, all TODOs added either need a bug number (TODO(#NN)) or a person's github user name. By default, I made irungentoo the owner of all toxcore TODOs, mannol the owner of toxav TODOs, and myself the owner of API TODOs.
In the future, all TODOs added either need a bug number (TODO(#NN)) or a
person's github user name. By default, I made irungentoo the owner of
all toxcore TODOs, mannol the owner of toxav TODOs, and myself the owner
of API TODOs.
This change is