Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bazel build version at 0.22.0 for CI. #1314

Merged
merged 1 commit into from
Mar 24, 2019
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Mar 24, 2019

To make this reproducible. With floating versions (always latest), this
can break any time a new bazel version is released.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Mar 24, 2019
@iphydf iphydf force-pushed the fix-bazel branch 2 times, most recently from 5cf838e to eb21124 Compare March 24, 2019 01:01
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #1314 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1314     +/-   ##
========================================
- Coverage    84.6%   84.2%   -0.4%     
========================================
  Files          85      85             
  Lines       15442   15442             
========================================
- Hits        13078   13017     -61     
- Misses       2364    2425     +61
Impacted Files Coverage Δ
toxcore/TCP_client.c 62.3% <0%> (-5.2%) ⬇️
toxcore/TCP_server.c 80.3% <0%> (-2.6%) ⬇️
toxav/msi.c 66.4% <0%> (-2%) ⬇️
auto_tests/toxav_basic_test.c 81.6% <0%> (-2%) ⬇️
toxcore/friend_connection.c 94.6% <0%> (-1.5%) ⬇️
toxav/toxav.c 69% <0%> (-1.3%) ⬇️
toxcore/LAN_discovery.c 84.9% <0%> (-1%) ⬇️
toxcore/net_crypto.c 95% <0%> (-0.3%) ⬇️
toxcore/onion_client.c 96.3% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14989f...a49cbe5. Read the comment docs.

To make this reproducible. With floating versions (always latest), this
can break any time a new bazel version is released.
@iphydf iphydf merged commit a49cbe5 into TokTok:master Mar 24, 2019
@iphydf iphydf deleted the fix-bazel branch March 24, 2019 22:13
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.10 May 20, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants