Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing TCP server test #1311

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

zugz
Copy link

@zugz zugz commented Mar 2, 2019

The test's intermittent failure may well be exposing a real bug in the
TCP relay and/or onion systems, but we can't find the bug, and keeping
the test is disrupting our CI.


This change is Reviewable

@zoff99
Copy link

zoff99 commented Mar 2, 2019

@zugz

./auto_tests/tox_many_tcp_test.c:27:6: error: no previous extern declaration for
      non-static variable 'enable_broken_tests'
      [-Werror,-Wmissing-variable-declarations]
bool enable_broken_tests = false;

Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #1311 into master will decrease coverage by 0.2%.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1311     +/-   ##
========================================
- Coverage    84.4%   84.2%   -0.3%     
========================================
  Files          85      85             
  Lines       15442   15443      +1     
========================================
- Hits        13047   13008     -39     
- Misses       2395    2435     +40
Impacted Files Coverage Δ
auto_tests/tox_many_tcp_test.c 56.1% <50%> (-43.9%) ⬇️
toxcore/ping_array.c 91.9% <0%> (-3.3%) ⬇️
toxcore/onion_client.c 95.6% <0%> (-0.8%) ⬇️
toxcore/TCP_connection.c 77.7% <0%> (-0.6%) ⬇️
toxcore/net_crypto.c 94.6% <0%> (-0.4%) ⬇️
toxav/toxav.c 68.7% <0%> (-0.2%) ⬇️
toxcore/DHT.c 77.7% <0%> (-0.1%) ⬇️
toxcore/Messenger.c 86.9% <0%> (-0.1%) ⬇️
auto_tests/toxav_many_test.c 97.2% <0%> (+0.6%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49cbe5...efff822. Read the comment docs.

The test's intermittent failure may well be exposing a real bug in the
TCP relay and/or onion systems, but we can't find the bug, and keeping
the test is disrupting our CI.
@zugz zugz merged commit efff822 into TokTok:master Apr 1, 2019
@zugz zugz deleted the disableFailingTCPTest branch April 1, 2019 20:47
@robinlinden robinlinden added this to the v0.2.10 milestone May 20, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants