Add some const qualifiers #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
approved these changes
Jan 12, 2019
toxcore/tox.c
Outdated
| @@ -330,7 +330,7 @@ bool tox_version_is_compatible(uint32_t major, uint32_t minor, uint32_t patch) | |||
|
|
|||
| static State_Load_Status state_load_callback(void *outer, const uint8_t *data, uint32_t length, uint16_t type) | |||
| { | |||
| Tox *tox = (Tox *)outer; | |||
| const Tox *tox = (Tox *)outer; | |||
There was a problem hiding this comment.
You can also change the (Tox *) to (const Tox *) for consistency.
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
========================================
- Coverage 83.2% 83% -0.3%
========================================
Files 82 82
Lines 14978 14962 -16
========================================
- Hits 12469 12425 -44
- Misses 2509 2537 +28
Continue to review full report at Codecov.
|
(Implementing suggestions of sudden6)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Implementing suggestions of sudden6)
This change is