Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge irungentoo/master back into toktok/master. #1282

Merged
merged 2 commits into from
Jan 6, 2019

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 3, 2019

This change is Reviewable

@iphydf iphydf added this to the v0.2.9 milestone Jan 3, 2019
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iphydf
❌ irungentoo
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #1282 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1282     +/-   ##
========================================
- Coverage    83.2%     83%   -0.2%     
========================================
  Files          82      82             
  Lines       14928   14928             
========================================
- Hits        12425   12405     -20     
- Misses       2503    2523     +20
Impacted Files Coverage Δ
toxcore/TCP_client.c 64.6% <0%> (-2.9%) ⬇️
toxcore/LAN_discovery.c 83% <0%> (-2.9%) ⬇️
toxcore/TCP_server.c 80.3% <0%> (-2.6%) ⬇️
toxcore/net_crypto.c 94.9% <0%> (-0.3%) ⬇️
toxav/msi.c 63.9% <0%> (-0.3%) ⬇️
toxcore/Messenger.c 87% <0%> (ø) ⬆️
toxcore/DHT.c 77.8% <0%> (ø) ⬆️
toxav/toxav.c 67.6% <0%> (+0.1%) ⬆️
toxcore/friend_connection.c 95.7% <0%> (+0.8%) ⬆️
auto_tests/toxav_basic_test.c 83.5% <0%> (+1.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b4ac4...765fd8a. Read the comment docs.

@iphydf iphydf force-pushed the merge-iru branch 2 times, most recently from e590733 to ea4877e Compare January 6, 2019 12:41
@iphydf iphydf unassigned zugz Jan 6, 2019
@iphydf iphydf modified the milestones: v0.2.x, v0.2.9 Jan 6, 2019
Copy link

@zoff99 zoff99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 0 of 1 approvals obtained

Copy link

@zoff99 zoff99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 0 of 1 approvals obtained

Copy link

@zoff99 zoff99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong: :lgtm_strong::lgtm_strong:

Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf merged commit 765fd8a into TokTok:master Jan 6, 2019
@iphydf iphydf deleted the merge-iru branch January 6, 2019 16:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants