Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return TOX_ERR_CONFERENCE_SEND_MESSAGE_NO_CONNECTION if we are not connected to any peers #1271

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

zugz
Copy link

@zugz zugz commented Nov 22, 2018

Closes #1269.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Nov 22, 2018
@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #1271 into master will decrease coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1271     +/-   ##
========================================
- Coverage    83.1%     83%   -0.1%     
========================================
  Files          82      82             
  Lines       14685   14685             
========================================
- Hits        12204   12193     -11     
- Misses       2481    2492     +11
Impacted Files Coverage Δ
toxcore/group.c 76.2% <100%> (ø) ⬆️
toxav/msi.c 66.2% <0%> (-0.6%) ⬇️
toxcore/net_crypto.c 93.2% <0%> (-0.5%) ⬇️
toxav/toxav.c 68.9% <0%> (-0.4%) ⬇️
toxcore/friend_connection.c 93.1% <0%> (-0.3%) ⬇️
toxcore/DHT.c 76.7% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60cd08e...0bf90df. Read the comment docs.

@zugz zugz merged commit 0bf90df into TokTok:master Nov 23, 2018
@zugz zugz deleted the confSendErr branch November 23, 2018 17:09
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants