Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "phase" script for travis build phases. #127

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 11, 2016

This is the first step towards unifying travis configs for toxcore,
hstox, and qtox.


This change is Reviewable

@GrayHatter
Copy link

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


.travis.yml, line 5 at r1 (raw file):

matrix:
  include:
    - env: BUILD=hstox ENV=linux

This is called $BUILD here, but $JOB in phase, one should be renamed.


other/travis/phase, line 13 at r1 (raw file):


try_source() {
  SCRIPT="other/travis/$1"

Should we not use ${JOB} here instead of $1 to make it more readable?


Comments from Reviewable

This is the first step towards unifying travis configs for toxcore,
hstox, and qtox.
@iphydf
Copy link
Member Author

iphydf commented Sep 11, 2016

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


.travis.yml, line 5 at r1 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

This is called $BUILD here, but $JOB in phase, one should be renamed.

Done.

other/travis/phase, line 13 at r1 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

Should we not use ${JOB} here instead of $1 to make it more readable?

That would be incorrect. `$1` is the first argument to `try_source` called below.

Comments from Reviewable

@iphydf iphydf assigned GrayHatter and unassigned nurupo Sep 11, 2016
@nurupo
Copy link
Member

nurupo commented Sep 11, 2016

:lgtm_strong:


Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


Comments from Reviewable

@GrayHatter
Copy link

:lgtm_strong:


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@GrayHatter
Copy link

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@iphydf iphydf closed this Sep 12, 2016
@iphydf iphydf deleted the phase branch September 12, 2016 11:11
@iphydf iphydf merged commit 2db31d9 into TokTok:master Sep 12, 2016
@iphydf iphydf modified the milestone: v0.0.1 Nov 5, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants