Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some hopefully helpful documentation to the functions in mono_time.h #1239

Merged
merged 1 commit into from
Nov 4, 2018

Conversation

zugz
Copy link

@zugz zugz commented Oct 31, 2018

(I found I couldn't remember whether get_mono_time returned unix time or
not, and had to source-dive to find out. This should make that
unnecessary next time!)


This change is Reviewable

(I found I couldn't remember whether get_mono_time returned unix time or
not, and had to source-dive to find out. This should make that
unnecessary next time!)
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #1239 into master will decrease coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1239     +/-   ##
========================================
- Coverage    83.4%     83%   -0.5%     
========================================
  Files          82      82             
  Lines       14685   14685             
========================================
- Hits        12251   12192     -59     
- Misses       2434    2493     +59
Impacted Files Coverage Δ
auto_tests/toxav_many_test.c 92.5% <0%> (-4.8%) ⬇️
toxav/msi.c 64.5% <0%> (-4.2%) ⬇️
toxav/toxav.c 67.1% <0%> (-3.1%) ⬇️
toxcore/group.c 76.2% <0%> (-0.4%) ⬇️
toxcore/friend_connection.c 94.2% <0%> (-0.3%) ⬇️
toxcore/net_crypto.c 94.7% <0%> (-0.3%) ⬇️
toxcore/Messenger.c 86.9% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cc805...b56166f. Read the comment docs.

Copy link
Member

@hugbubby hugbubby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds comments
-0.5% code coverage

O.o

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf added this to the v0.2.x milestone Nov 4, 2018
@iphydf iphydf merged commit b56166f into TokTok:master Nov 4, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants