Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bool for IPv6 flag in test programs and DHT_bootstrap. #1231

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Oct 9, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Oct 9, 2018
Copy link
Member

@hugbubby hugbubby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: 0 of 1 approvals obtained

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #1231 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1231     +/-   ##
========================================
- Coverage    83.1%   82.8%   -0.3%     
========================================
  Files          82      82             
  Lines       14692   14647     -45     
========================================
- Hits        12214   12139     -75     
- Misses       2478    2508     +30
Impacted Files Coverage Δ
testing/misc_tools.c 55.1% <0%> (ø) ⬆️
toxcore/TCP_server.c 75.9% <0%> (-4.4%) ⬇️
toxav/toxav.c 67.3% <0%> (-0.7%) ⬇️
toxcore/Messenger.c 86.5% <0%> (-0.7%) ⬇️
toxav/msi.c 63.9% <0%> (-0.3%) ⬇️
toxcore/DHT.c 76.6% <0%> (-0.3%) ⬇️
toxcore/onion_client.c 95.9% <0%> (-0.2%) ⬇️
toxcore/network.c 82.3% <0%> (+0.2%) ⬆️
toxcore/friend_connection.c 94.5% <0%> (+0.2%) ⬆️
auto_tests/save_load_test.c 98.6% <0%> (+0.5%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9beef...700accb. Read the comment docs.

@iphydf iphydf merged commit 700accb into TokTok:master Oct 16, 2018
@iphydf iphydf deleted the bool-ipv6 branch October 16, 2018 22:21
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants