Consistently use camel case enum names. #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
approved these changes
Oct 9, 2018
There was a problem hiding this comment.
Reviewed 33 of 33 files at r1.
Reviewable status: 0 of 1 approvals obtained
Including in tests and implementation files.
iphydf
force-pushed
the
camel-case-enums
branch
from
7431b97
to
605dfe8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
========================================
- Coverage 82.9% 82.9% -0.1%
========================================
Files 82 82
Lines 14647 14647
========================================
- Hits 12151 12144 -7
- Misses 2496 2503 +7
Continue to review full report at Codecov.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including in tests and implementation files.
This change is