Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of IPv6 in tests if not supported (e.g. on Travis). #1224

Merged
merged 1 commit into from
Oct 7, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Oct 6, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Oct 6, 2018
@iphydf iphydf force-pushed the ipv6 branch 2 times, most recently from 9b5b1ce to a07e82e Compare October 6, 2018 21:19
@codecov
Copy link

codecov bot commented Oct 6, 2018

Codecov Report

Merging #1224 into master will decrease coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1224     +/-   ##
========================================
- Coverage    83.2%   82.6%   -0.6%     
========================================
  Files          82      81      -1     
  Lines       14647   14564     -83     
========================================
- Hits        12195   12040    -155     
- Misses       2452    2524     +72
Impacted Files Coverage Δ
toxcore/crypto_core_test.cc 90.3% <0%> (-9.7%) ⬇️
toxav/msi.c 64.5% <0%> (-4%) ⬇️
toxcore/network.c 79.5% <0%> (-3.9%) ⬇️
toxav/toxav.c 67.1% <0%> (-2.9%) ⬇️
auto_tests/toxav_basic_test.c 81.6% <0%> (-2%) ⬇️
toxcore/friend_connection.c 94.5% <0%> (-1.5%) ⬇️
toxcore/LAN_discovery.c 84.9% <0%> (-1%) ⬇️
toxcore/net_crypto.c 94.7% <0%> (-0.4%) ⬇️
toxcore/Messenger.c 86.5% <0%> (-0.3%) ⬇️
toxcore/onion_client.c 95.9% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7365b1...b2b96b1. Read the comment docs.

@iphydf iphydf changed the title WIP: Avoid use of IPv6 in tests if not supported (e.g. on Travis). Avoid use of IPv6 in tests if not supported (e.g. on Travis). Oct 6, 2018
@iphydf iphydf merged commit b2b96b1 into TokTok:master Oct 7, 2018
@iphydf iphydf deleted the ipv6 branch October 7, 2018 15:00
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants