-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AUTOTEST option to CMakeLists.txt #1223
Conversation
|
CMakeLists.txt
Outdated
endif() | ||
option(AUTOTEST "Enable Automated regression tests" OFF) | ||
if(AUTOTEST) | ||
add_library(misc_tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misc_tools is needed for other things than auto tests. Better add the condition to the existing if
inside function(auto_test target)
.
CMakeLists.txt
Outdated
set_tests_properties(${target} PROPERTIES TIMEOUT "${TEST_TIMEOUT_SECONDS}") | ||
set_property(TEST ${target} PROPERTY ENVIRONMENT "LLVM_PROFILE_FILE=${target}.profraw") | ||
option(AUTOTEST "Enable Automated regression tests" OFF) | ||
if(AUTOTEST) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add the condition inside the existing if
?
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
========================================
- Coverage 82.9% 82.9% -0.1%
========================================
Files 82 82
Lines 14647 14647
========================================
- Hits 12152 12147 -5
- Misses 2495 2500 +5
Continue to review full report at Codecov.
|
Can you update README.md with the new option? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c17e1c6
to
1c4d9b6
Compare
This change is