Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Alpine Linux bootstrap daemon dockerfile. #1210

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 26, 2018

We can add it back when there is a test for it. For now, we don't know
whether it works and don't have tests to make sure it keeps working.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 26, 2018
@iphydf
Copy link
Member Author

iphydf commented Sep 26, 2018

@romik-g FYI.

Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #1210 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1210     +/-   ##
========================================
- Coverage    82.8%   82.6%   -0.3%     
========================================
  Files          82      80      -2     
  Lines       14647   14620     -27     
========================================
- Hits        12140   12087     -53     
- Misses       2507    2533     +26
Impacted Files Coverage Δ
toxcore/net_crypto.c 92.8% <0%> (-1.9%) ⬇️
toxcore/LAN_discovery.c 83.9% <0%> (-1.9%) ⬇️
toxav/msi.c 63.6% <0%> (-0.9%) ⬇️
toxcore/TCP_connection.c 78% <0%> (-0.2%) ⬇️
toxcore/onion_client.c 95.3% <0%> (-0.2%) ⬇️
toxav/toxav.c 67.6% <0%> (ø) ⬆️
auto_tests/bootstrap_test.c
auto_tests/tcp_relay_test.c
toxcore/friend_connection.c 94.8% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d6422...77e025f. Read the comment docs.

We can add it back when there is a test for it. For now, we don't know
whether it works and don't have tests to make sure it keeps working.
@iphydf iphydf merged commit 77e025f into TokTok:master Oct 8, 2018
@iphydf iphydf deleted the rm-alpine-image branch October 8, 2018 23:54
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants