Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a function-like macro and replace it with a function. #1208

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 26, 2018

No use making this a macro. LTO will inline this anyway, if we care about
performance. Generally, we avoid function-like macros that can be functions.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 26, 2018
No use making this a macro. LTO will inline this anyway, if we care about
performance. Generally, we avoid function-like macros that can be functions.
@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #1208 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1208     +/-   ##
========================================
- Coverage      83%   82.7%   -0.3%     
========================================
  Files          82      82             
  Lines       14645   14647      +2     
========================================
- Hits        12158   12120     -38     
- Misses       2487    2527     +40
Impacted Files Coverage Δ
toxcore/state.c 61.1% <0%> (-3.6%) ⬇️
auto_tests/toxav_many_test.c 92.5% <0%> (-4.1%) ⬇️
auto_tests/network_test.c 97.5% <0%> (-2.5%) ⬇️
toxcore/net_crypto.c 92.9% <0%> (-1.6%) ⬇️
toxav/audio.c 65.7% <0%> (-1.5%) ⬇️
toxav/toxav.c 67.4% <0%> (-1.2%) ⬇️
toxcore/group.c 76% <0%> (-0.4%) ⬇️
toxav/msi.c 65.3% <0%> (-0.3%) ⬇️
toxcore/onion_client.c 95.9% <0%> (-0.2%) ⬇️
toxcore/friend_connection.c 94.5% <0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a94d032...c7365b1. Read the comment docs.

@iphydf iphydf merged commit c7365b1 into TokTok:master Sep 26, 2018
@iphydf iphydf deleted the rm-state-macro branch September 26, 2018 22:16
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants