Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LAN_discovery to the list of apidsl-generated files. #1206

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 25, 2018

So it gets regenerated when the .api.h file changes.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 25, 2018
@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #1206 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1206     +/-   ##
========================================
+ Coverage    82.7%   82.9%   +0.1%     
========================================
  Files          82      82             
  Lines       14647   14647             
========================================
+ Hits        12117   12144     +27     
+ Misses       2530    2503     -27
Impacted Files Coverage Δ
toxcore/LAN_discovery.c 83% <0%> (-2.9%) ⬇️
toxcore/friend_connection.c 93.9% <0%> (-0.6%) ⬇️
toxcore/DHT.c 76.7% <0%> (ø) ⬆️
toxcore/onion_client.c 96.1% <0%> (+0.1%) ⬆️
toxcore/net_crypto.c 94.3% <0%> (+0.7%) ⬆️
toxav/toxav.c 68.5% <0%> (+1.4%) ⬆️
toxav/msi.c 65.6% <0%> (+1.9%) ⬆️
auto_tests/toxav_many_test.c 96.6% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e58f3c...15d6422. Read the comment docs.

Copy link
Member

@hugbubby hugbubby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained

So it gets regenerated when the .api.h file changes.
@iphydf iphydf merged commit 15d6422 into TokTok:master Oct 8, 2018
@iphydf iphydf deleted the apidsl-lan-disc branch October 8, 2018 22:59
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants