Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve cmake build for MSVC." #1203

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 24, 2018

This reverts commit f87f871.

Fixes #1201.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 24, 2018
Copy link

@sphaerophoria sphaerophoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @sphaerophoria)

Copy link

@sphaerophoria sphaerophoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 0 of 1 approvals obtained

Copy link

@sphaerophoria sphaerophoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 0 of 1 approvals obtained

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #1203 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1203     +/-   ##
========================================
+ Coverage    82.7%   82.9%   +0.1%     
========================================
  Files          82      82             
  Lines       14645   14646      +1     
========================================
+ Hits        12123   12146     +23     
+ Misses       2522    2500     -22
Impacted Files Coverage Δ
toxav/msi.c 65.9% <ø> (+1.9%) ⬆️
toxcore/crypto_core_test.cc 90.3% <0%> (-9.7%) ⬇️
auto_tests/toxav_many_test.c 92.5% <0%> (-4.1%) ⬇️
toxcore/net_crypto.c 93.1% <0%> (-0.2%) ⬇️
toxcore/onion_client.c 95.9% <0%> (-0.2%) ⬇️
toxcore/DHT.c 76.6% <0%> (-0.1%) ⬇️
toxcore/Messenger.c 86.5% <0%> (-0.1%) ⬇️
toxav/toxav.c 68.2% <0%> (+0.4%) ⬆️
auto_tests/toxav_basic_test.c 83.5% <0%> (+1.9%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d6e3f...bfd288c. Read the comment docs.

@iphydf iphydf merged commit bfd288c into TokTok:master Sep 24, 2018
@iphydf iphydf deleted the revert-msvc-change branch September 24, 2018 22:39
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants