-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Improve cmake build for MSVC." #1203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @sphaerophoria)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained
This reverts commit f87f871.
ad01fce
to
bfd288c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
========================================
+ Coverage 82.7% 82.9% +0.1%
========================================
Files 82 82
Lines 14645 14646 +1
========================================
+ Hits 12123 12146 +23
+ Misses 2522 2500 -22
Continue to review full report at Codecov.
|
This reverts commit f87f871.
Fixes #1201.
This change is